Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase default SMTP timeout #10271

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: increase default SMTP timeout #10271

merged 1 commit into from
Oct 17, 2024

Conversation

miaulalala
Copy link
Contributor

These are the RFC recommendations:

Recommended Timeout Values:
    Initial Connection: Set the timeout for the initial 220 message to at least 5 minutes.
    Mail Commands: Allocate a minimum of 5 minutes for both the MAIL and RCPT commands.
    Data Initiation: Allow at least 2 minutes for initiating the DATA command.
    Data Block: Set a timeout of at least 3 minutes for sending a data block.
    Data Termination: Provide a generous 10-minute timeout for terminating the DATA command.
    Server Timeout: Configure the server to have a timeout of at least 5 minutes.

We have to be cognizant of the PHP timeout, so 5 minutes are out.

20 seconds to start, otherwise we need to see what else we can do and if we need to recommend higher PHP timeouts as well as a higher SMTP timeout for the Mail app.

@miaulalala
fix: increase default SMTP timeout
e7e62a3 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala added this to the v4.1.0 milestone Oct 17, 2024
@miaulalala miaulalala self-assigned this Oct 17, 2024
@miaulalala
Copy link
Contributor Author

/backport to stable4.0

ChristophWurst
ChristophWurst reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 does it influence autodiscovery?

@miaulalala
Copy link
Contributor Author

👍 does it influence autodiscovery?

No, the Isp query runs via Guzzle

@ChristophWurst
Copy link
Member

I meant https://github.com/nextcloud/mail/blob/main/lib/Service/AutoConfig/ConnectivityTester.php but the timeout is static

@miaulalala miaulalala merged commit 3d8d4f1 into main Oct 17, 2024
35 checks passed
@miaulalala miaulalala deleted the fix/update-smtp-default branch October 17, 2024 15:28
@backportbot backportbot bot mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

Assignees

@miaulalala miaulalala

Labels
3. to review bug feature: outbox
Projects
💌 📅 👥 Groupware team
Status: ☑️ Done
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@miaulalala @ChristophWurst